Handle backwards compatibility for old HPOS compatibility format #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommerce/class-sv-wc-plugin.php
Outdated
Comment on lines
195
to
201
| if ( | ||
| array_key_exists('supports_hpos', $args) && | ||
| ! isset($args['supported_features']['hpos']) | ||
| ) { | ||
| $args['supported_features']['hpos'] = $args['supports_hpos']; | ||
| unset($args['supports_hpos']); | ||
| } |
There was a problem hiding this comment.
How about we unset the supports_hpos anyways without checking if supported_features.hpos is set? As well as making sure supported_features key is initialized
There was a problem hiding this comment.
LGTM @nmolham-godaddy ! Thank you!
nmolham-godaddy
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds backwards compatibility for the old HPOS compatibility format. If the old format is detected, it's converted to the new one.
Story: https://godaddy-corp.atlassian.net/browse/MWC-17548
Details
Additional details to expand on the summary, if needed
QA
Setup
You should see a notice like this:
Steps
woocommerce-cost-of-goods.phpfile, edit theinit_plugin()method like so:public function init_plugin() { if ( ! $this->plugins_compatible() ) { return; } + require_once plugin_dir_path(__FILE__) . '/vendor/autoload.php'; $this->load_framework(); // load the main plugin class require_once( plugin_dir_path( __FILE__ ) . 'class-wc-cog.php' ); // fire it up! wc_cog(); }Before merge