Merge pull request #1168 from godaddy/pre-commit-cleanup

exclude generated source from pre-commit hooks, global cleanup via `pre-commit run --all`
godaddy · Jan 13, 2025 · 05731a9 · 05731a9
2 parents 8e6c8a0 + 884ca22
commit 05731a9
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 6 deletions.
diff --git a/.github/workflows/go-securememory-ci.yml b/.github/workflows/go-securememory-ci.yml
@@ -101,4 +101,3 @@ jobs:
         with:
           paths: 'go/securememory/junit_results.xml'
         if: always()
-
diff --git a/.github/workflows/java-securememory-ci.yml b/.github/workflows/java-securememory-ci.yml
@@ -90,4 +90,3 @@ jobs:
         with:
           paths: 'java/secure-memory/target/surefire-reports/TEST-*.xml'
         if: always()
-
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -1,3 +1,4 @@
+exclude: '^.*generated.*$'
 repos:
 -   repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v5.0.0

diff --git a/csharp/AppEncryption/AppEncryption/AppEncryption.csproj b/csharp/AppEncryption/AppEncryption/AppEncryption.csproj
@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <PackageId>GoDaddy.Asherah.AppEncryption</PackageId>
     <Title>AppEncryption</Title>

diff --git a/csharp/SecureMemory/SecureMemory/SecureMemory.csproj b/csharp/SecureMemory/SecureMemory/SecureMemory.csproj
@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <PackageId>GoDaddy.Asherah.SecureMemory</PackageId>

diff --git a/java/app-encryption/README.md b/java/app-encryption/README.md
@@ -139,7 +139,7 @@ AwsKmsClientFactory awsKmsClientFactory = ...;
 KeyManagementService keyManagementService = AwsKeyManagementServiceImpl.newBuilder(regionMap, "us-east-1")
     .withAwsKmsClientFactory(awsKmsClientFactory)
     .build();
-``` 
+```
 
 #### Static KMS (FOR TESTING ONLY)
 

diff --git a/samples/csharp/ReferenceApp/README.md b/samples/csharp/ReferenceApp/README.md
@@ -175,4 +175,3 @@ follows:
 
   --version                      Display version information.
 ```
-
Original file line number	Diff line number	Diff line change
Expand Up		@@ -101,4 +101,3 @@ jobs:
		with:
		paths: 'go/securememory/junit_results.xml'
		if: always()
Original file line number	Diff line number	Diff line change
Expand Up		@@ -90,4 +90,3 @@ jobs:
		with:
		paths: 'java/secure-memory/target/surefire-reports/TEST-*.xml'
		if: always()
Original file line number	Diff line number	Diff line change
Expand Up		@@ -175,4 +175,3 @@ follows:

		--version Display version information.
		```