Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to GitHub Actions for CI/CD #361

Merged
merged 6 commits into from
Jun 1, 2021
Merged

Switch to GitHub Actions for CI/CD #361

merged 6 commits into from
Jun 1, 2021

Conversation

tarkatronic
Copy link
Contributor

@tarkatronic tarkatronic commented Apr 21, 2021 •
edited
Loading

Necessary parts:

CI components

  • Java Secure Memory
  • Java App Encryption
  • Java Reference App
  • Java Server
  • C# Logging
  • C# Secure Memory
  • C# App Encryption
  • C# Reference App
  • Go Secure Memory
  • Go App Encryption
  • Go Reference App
  • Go Server
  • Server Samples
  • Cross-Language Tests

CD components

  • Deploy Java Secure Memory
  • Deploy Java App Encryption
  • Deploy C# Logging
  • Deploy C# Secure Memory
  • Deploy C# App Encryption
  • Deploy Go Secure Memory
  • Deploy Go App Encryption

@tarkatronic tarkatronic force-pushed the github-actions branch 12 times, most recently from 2095f24 to cb2c499 Compare April 28, 2021 21:54
@tarkatronic tarkatronic force-pushed the github-actions branch 2 times, most recently from cd8515b to 6a87727 Compare April 30, 2021 19:44
@tarkatronic tarkatronic requested a review from aka-bo May 7, 2021 19:37
aka-bo
aka-bo reviewed May 10, 2021
View reviewed changes
.github/workflows/ci.yml
options: --ulimit core=-1 --ulimit memlock=-1:-1
steps:
- name: Checkout the repository
uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While pinning actions via the commit SHA (in lieu of tags) is good practice from a security/hardening standpoint, as it guarantees cross-build consistency, it means we're on the hook for ensuring we don't miss out on potentially critical security updates. What's the plan for ensuring we remain up-to-date on future updates for these actions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure dependabot can help us with these! We will have to specifically set up a dependabot.yml, but there is a github-actions package-ecosystem value.

.github/workflows/release_artifacts.yaml Outdated Show resolved Hide resolved
build/csharp/release_prod.sh Outdated Show resolved Hide resolved
aka-bo
aka-bo requested changes May 11, 2021
View reviewed changes
Copy link
Contributor

@aka-bo aka-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline comments/suggestions aside, I'd like to see the majority of the ~70 commits squashed prior to merge.

.github/workflows/release_artifacts.yaml Outdated Show resolved Hide resolved
.github/workflows/release_artifacts.yaml Outdated Show resolved Hide resolved
.github/workflows/release_artifacts.yaml Outdated Show resolved Hide resolved
build/go/benchmark_test.sh Outdated Show resolved Hide resolved
csharp/AppEncryption/AppEncryption.Tests/AppEncryption/Persistence/DynamoDbMetastoreImplTest.cs Outdated Show resolved Hide resolved
csharp/AppEncryption/AppEncryption.Tests/AppEncryption/Persistence/DynamoDbMetastoreImplTest.cs Outdated Show resolved Hide resolved
csharp/AppEncryption/AppEncryption.Tests/AppEncryption/Persistence/DynamoDbMetastoreImplTest.cs Outdated Show resolved Hide resolved
csharp/AppEncryption/AppEncryption.Tests/AppEncryption/SessionFactoryTest.cs Show resolved Hide resolved
csharp/AppEncryption/AppEncryption.Tests/AppEncryption/SessionFactoryTest.cs Show resolved Hide resolved
server/java/pom.xml Outdated Show resolved Hide resolved
@sushantmimani sushantmimani force-pushed the github-actions branch 3 times, most recently from ba06f23 to 10d2ede Compare May 12, 2021 16:10
@sushantmimani
Copy link
Contributor

This PR also skips running 2 integration tests that fail intermittently in the CI pipeline.
#370 has been raised to address the issue of the intermittently failing tests.

@sushantmimani sushantmimani marked this pull request as ready for review May 21, 2021 19:17
@sushantmimani sushantmimani requested a review from aka-bo May 21, 2021 19:17
tarkatronic
tarkatronic commented May 24, 2021
View reviewed changes
build/csharp/release_prod.sh Outdated Show resolved Hide resolved
build/go/benchmark_test.sh Outdated Show resolved Hide resolved
.github/workflows/set_env_variables.sh Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
aka-bo
aka-bo approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@aka-bo aka-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sushantmimani sushantmimani merged commit b6a0f78 into master Jun 1, 2021
@sushantmimani sushantmimani deleted the github-actions branch June 1, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aka-bo aka-bo aka-bo approved these changes

@sushantmimani sushantmimani sushantmimani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tarkatronic @sushantmimani @aka-bo @smimani-godaddy