Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SetMustMany #368

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add SetMustMany #368

wants to merge 1 commit into from

Conversation

malaupa
Copy link

@malaupa malaupa commented Apr 25, 2023

  • to set many properties at once and to emit only one signal

guelfey
guelfey reviewed May 21, 2023
View reviewed changes
Copy link
Member

@guelfey guelfey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also consider the linting output

prop/prop.go Outdated Show resolved Hide resolved
prop/prop.go Outdated Show resolved Hide resolved
@malaupa malaupa requested a review from guelfey May 22, 2023 07:23
@malaupa
Copy link
Author

malaupa commented May 22, 2023 •
edited
Loading

I have fixed all findings. I hope all is fine now.

@malaupa malaupa force-pushed the master branch 2 times, most recently from 92d7021 to 9038b08 Compare May 22, 2023 08:08
guelfey
guelfey reviewed May 22, 2023
View reviewed changes
prop/prop_test.go Outdated Show resolved Hide resolved
@malaupa
add SetMustMany
50474b9 
* to set many properties at once and to emit only one signal
@malaupa malaupa requested a review from guelfey May 25, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guelfey guelfey Awaiting requested review from guelfey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malaupa @guelfey