Improve API soundness wrt reference counted Gd
#377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the safety invariants that need to be upheld for reference counted
Gd
.Make
Mem::maybe_dec_ref
an unsafe function, as it can be used to bypass the safety invariants of a reference countedGd
.The
maybe_dec_ref
api is admittedly private (doc-hidden), however i still believe it is useful for us to properly label it asunsafe
anyway. So we can more easily tell that it's being used correctly.