-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/func renaming #378
Conversation
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-378 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
Continuing from the previous PR as GitHub (sensibly) closes the PR if you change the branch name, and I wasn't able to re-open the PR.
I don't think many people care about the branch name 😉 the PR title is more important. In the future, please try to keep it in one pull request, because now all the review and change history is gone, which makes things a bit harder to follow.
a7baf0d
to
5f70989
Compare
Will squash the commits once |
79df477
to
0a068d7
Compare
0a068d7
to
d74aa47
Compare
* Modify func macro to accept a 'rename = ...' attribute * Add integration tests to cover renamed functions
d74aa47
to
d6589fc
Compare
Ready for re-review. Changes from the initial reviews have been made sans the
|
Thanks a lot for the feature and all the amendments 🙂 |
Comments
Continuing from the previous PR as GitHub (sensibly) closes the PR if you change the branch name, and I wasn't able to re-open the PR.
Please let me know if it would be better to break this functionality out like with field_var.rs. I tried to keep the number of changed files to a minimum.
There are alsoMost have been resolved. There is aTODO
s left in the file as a starting point for discussion, but feel free to start picking at the PR wherever you want.TODO
left in the code to indicate where default values on the GDScript side might be implemented.Still todo
signal renamingunit tests?Covered by integration teststype aliasFunction
toSignal
for readability?FuncDefinition
insrc/method_registration/mod.rs
is okay?src/godot_api.rs:extract_attributes
is okay?