Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup some minor things #389

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Conversation

lilizoey
Copy link
Member

  • Add VariantConversionError::VariantIsNil
  • Implement Display and Error for VariantConversionError
  • Remove Deref impl for Object with target () (this can cause weird things like being able to clone a Gd<Object> and get back a ())
  • Add an #[allow] for a clippy lint that was added in 1.72

@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-389

@Bromeon Bromeon added quality-of-life No new functionality, but improves ergonomics/internals c: core Core components labels Aug 26, 2023
@Bromeon
Copy link
Member

Bromeon commented Aug 26, 2023

Thanks a lot! There seems to be a new clippy issue, other than that looks good 🙂

@lilizoey
Copy link
Member Author

Thanks a lot! There seems to be a new clippy issue, other than that looks good 🙂

apparently ./check.sh clippy runs with no-default-features and not all-targets unlike the CI which seems to make that clippy lint not get triggered.

- Implement `Display` and `Error` for `VariantConversionError`
- Remove `Deref` impl for `Object` with target `()`
- Add some `#[allow]` for clippy lints that were added in 1.72
@Bromeon Bromeon added this pull request to the merge queue Aug 26, 2023
@Bromeon
Copy link
Member

Bromeon commented Aug 26, 2023

Thanks! I'll fix the local check.sh during my next PR.

Merged via the queue into godot-rust:master with commit bb2be22 Aug 26, 2023
14 checks passed
@Bromeon
Copy link
Member

Bromeon commented Aug 27, 2023

Thanks! I'll fix the local check.sh during my next PR.

Actually, I noticed this was done deliberately, because changing features means we have to recompile everything. And for itest, we don't want to run with the full codegen locally.

So I don't think there's that much we can do; hopefully we can one day improve compile times to the point where codegen-full will no longer be necessary 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: core Core components quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants