Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up file structure in godot-macros and itest crates #390

Merged
merged 4 commits into from
Aug 27, 2023

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Aug 27, 2023

No functional changes, except 2 removed tests that overlapped with existing ones.

@Bromeon Bromeon added the quality-of-life No new functionality, but improves ergonomics/internals label Aug 27, 2023
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-390

@Bromeon Bromeon force-pushed the qol/restructure-modules branch from b43e1e3 to edbdcfe Compare August 27, 2023 18:21
Organize by semantics, grouping class-related macros together.
Also move helper types into their own data_models directory.
Changes:
* Group tests by shared semantics, rather than having all on top level.
* Remove 2 tests in `builtin.rs` (Vector2, VariantArray), already covered through unit-tests and other itests.
@Bromeon Bromeon force-pushed the qol/restructure-modules branch from edbdcfe to 64d059e Compare August 27, 2023 18:27
@Bromeon Bromeon added this pull request to the merge queue Aug 27, 2023
Merged via the queue into master with commit bdb243f Aug 27, 2023
@Bromeon Bromeon deleted the qol/restructure-modules branch August 27, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants