Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enum_test.rs accidentally excluded from itest #931

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

0x53A
Copy link
Contributor

@0x53A 0x53A commented Oct 26, 2024

I randomly notice that the file enum_tests.rs was not included in the project, and therefore not compiled and tested.

image

If not including it was on purpose pls just close the PR

@Bromeon
Copy link
Member

Bromeon commented Oct 26, 2024

Good catch, that's definitely not intended. Thank you!

Could you eventually squash the commits to 1? Also, let me know if you need help with the CI that now fails 🙂

@Bromeon Bromeon added bug c: tooling CI, automation, tools labels Oct 26, 2024
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-931

@0x53A
Copy link
Contributor Author

0x53A commented Oct 26, 2024

done(, i hope).

what's the command to run itest locally?

@Bromeon Bromeon added this pull request to the merge queue Oct 27, 2024
@Bromeon
Copy link
Member

Bromeon commented Oct 27, 2024

what's the command to run itest locally?

./check.sh itest, see also this page in the book 🙂

Note that local testing is best-effort and not 100% the same as CI, so in case of discrepancies, consider CI the authority.

@Bromeon Bromeon changed the title [itest] add enum_test to mod.rs Fix enum_test.rs accidentally excluded from itest Oct 27, 2024
Merged via the queue into godot-rust:master with commit 5e9b965 Oct 27, 2024
15 checks passed
@0x53A 0x53A deleted the dev-add-itest-enum_test branch November 7, 2024 02:21
@Bromeon Bromeon added this to the 0.2 milestone Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug c: tooling CI, automation, tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants