Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hint_string tests to account for Godot 4.4 floats with .0 formatting #936

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Update hint_string tests to account for Godot 4.4 floats with .0 formatting #936

merged 1 commit into from
Nov 3, 2024

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Nov 3, 2024

Busywork due to breaking change in godotengine/godot#47502, which made our CI no longer pass.

We explicitly don't register hint_string with trailing .0 yet, since

  • it's unclear if that change is permanent, depending on user feedback
  • GDExtension must remain compatible with old formats, so we test that

@Bromeon Bromeon added quality-of-life No new functionality, but improves ergonomics/internals status: upstream Depending on upstream fix (typically Godot) c: register Register classes, functions and other symbols to GDScript labels Nov 3, 2024
@Bromeon Bromeon added this pull request to the merge queue Nov 3, 2024
@Bromeon Bromeon removed this pull request from the merge queue due to a manual request Nov 3, 2024
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-936

@Bromeon Bromeon added this pull request to the merge queue Nov 3, 2024
Merged via the queue into master with commit 337ebbd Nov 3, 2024
15 checks passed
@Bromeon Bromeon deleted the qol/float-formatting branch November 3, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: register Register classes, functions and other symbols to GDScript quality-of-life No new functionality, but improves ergonomics/internals status: upstream Depending on upstream fix (typically Godot)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bromeon @GodotRust