-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String argument conversion + AsArg
trait
#940
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
feature
Adds functionality to the library
c: core
Core components
c: engine
Godot classes (nodes, resources, ...)
labels
Nov 3, 2024
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-940 |
Bromeon
force-pushed
the
feature/string-args
branch
from
November 4, 2024 16:29
04909cb
to
b00e7ae
Compare
Bromeon
force-pushed
the
feature/string-args
branch
from
November 4, 2024 17:43
b00e7ae
to
12778bd
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 4, 2024
0x53A
added a commit
to 0x53A/gdext_coroutines
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
Requires SemVer bump
c: core
Core components
c: engine
Godot classes (nodes, resources, ...)
feature
Adds functionality to the library
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a colossal PR, simply because the changes go very deep into code generation and touch all the foundations:
AsArg<T>
trait for generic passing of string arguments.impl AsArg<T>
for strings.AsArg<T>
for generic argument passing insideArray<T>
andPacked*Array
.itest
,examples
as well as higher-level internal code.TLDR: instead of
you now write:
There are still some rough edges, but it's a mergeable start, and I'd like to iteratively improve it based on user feedback. Since the whole argument passing has been fundamentally reworked lately (object arguments in #800 + reference passing in #900 and #906), there is a lot that can be made more ergonomic and consistent in the future.