Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: skip notify-docs job when running in a fork #945

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

0x53A
Copy link
Contributor

@0x53A 0x53A commented Nov 6, 2024

see my comment here #933 (comment)

This workflow currently also gets triggered in a fork (if the fork has Actions enabled) because of:

  push:
    branches:
      - master

running the workflow in a fork doesn't hurt, since the fork can't actually update the docs, but not running it feels a little cleaner

@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-945

Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Can you check against the github.repository_owner instead? That doesn't break in case we rename the repo.

Also, this condition is currently on a job level -- does it not cause any issues if the workflow starts and its one job is skipped? Will it display as skipped or not at all?

(I don't think it's possible to have the condition on a workflow level, let me know if you find a way 🤔)

@Bromeon Bromeon changed the title [ci] update-docs: skip this workflow when running in a fork Skip notify-docs workflow when running in a fork Nov 6, 2024
@Bromeon Bromeon added quality-of-life No new functionality, but improves ergonomics/internals c: tooling CI, automation, tools labels Nov 6, 2024
@Bromeon Bromeon changed the title Skip notify-docs workflow when running in a fork Skip notify-docs job when running in a fork Nov 6, 2024
@Bromeon Bromeon changed the title Skip notify-docs job when running in a fork CI: skip notify-docs job when running in a fork Nov 6, 2024
@0x53A
Copy link
Contributor Author

0x53A commented Nov 6, 2024

Can you check against the github.repository_owner instead?

done

Also, this condition is currently on a job level [...] Will it display as skipped or not at all?

I have no idea, I'd assume it'll show as grey.

(I don't think it's possible to have the condition on a workflow level, let me know if you find a way 🤔)

Yeah I couldn't find any if at the top level either

@Bromeon Bromeon added this pull request to the merge queue Nov 7, 2024
@Bromeon
Copy link
Member

Bromeon commented Nov 7, 2024

Thank you! 🙂

Merged via the queue into godot-rust:master with commit 3a37c2a Nov 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: tooling CI, automation, tools quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants