Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename a few remaining occurrences of #[export] #935

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Aug 31, 2022

Forgot to include this commit in #933.

bors r+

@Bromeon Bromeon added c: export Component: export (mod export, derive) quality-of-life No new functionality, but improves ergonomics/internals labels Aug 31, 2022
@Bromeon Bromeon added this to the v0.10.1 milestone Aug 31, 2022
bors bot added a commit that referenced this pull request Aug 31, 2022
935: Rename a few remaining occurrences of #[export] r=Bromeon a=Bromeon

Forgot to include this commit in #933.

bors r+

Co-authored-by: Jan Haller <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 31, 2022

Build failed:

@Bromeon Bromeon force-pushed the qol/export-syntax-2 branch 2 times, most recently from 1268b26 to cc7919b Compare August 31, 2022 17:35
@Bromeon
Copy link
Member Author

Bromeon commented Aug 31, 2022

bors r+

bors bot added a commit that referenced this pull request Aug 31, 2022
935: Rename a few remaining occurrences of #[export] r=Bromeon a=Bromeon

Forgot to include this commit in #933.

bors r+

Co-authored-by: Jan Haller <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 31, 2022

Build failed:

This wasn't necessary so far, but it makes sense that different dependency versions can lead to different error messages.
We only run UI tests against one stable Rust version.
@Bromeon
Copy link
Member Author

Bromeon commented Aug 31, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 31, 2022

Build succeeded:

@bors bors bot merged commit efa994e into godot-rust:master Aug 31, 2022
@Bromeon Bromeon deleted the qol/export-syntax-2 branch August 31, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: export Component: export (mod export, derive) quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant