Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style: Replace _NO_DISCARD_ macro with [[nodiscard]] #1713

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Style: Replace _NO_DISCARD_ macro with [[nodiscard]] #1713

merged 1 commit into from
Feb 21, 2025

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Feb 20, 2025

C++17 natively accepts the attribute syntax, so the macro was entirely vestigial.

@Repiteo Repiteo added the enhancement This is an enhancement on the current functionality label Feb 20, 2025
@Repiteo Repiteo requested a review from a team as a code owner February 20, 2025 15:26
dsnopek
dsnopek approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsnopek dsnopek merged commit 48baa0c into godotengine:master Feb 21, 2025
11 checks passed
@dsnopek dsnopek added this to the 4.x milestone Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

@Ivorforce Ivorforce Ivorforce approved these changes

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.
3 participants
@Repiteo @dsnopek @Ivorforce