Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add touch screen support for 3d/platformer #1128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add touch screen support for 3d/platformer #1128

wants to merge 1 commit into from

Conversation

shahriarlabib000
Copy link
Contributor

@shahriarlabib000 shahriarlabib000 commented Oct 31, 2024 •
edited
Loading

Also updated gui/input_mapping to 4.3.stable by accident

@shahriarlabib000 shahriarlabib000 force-pushed the touchScreen branch 2 times, most recently from 958bd7b to e188eaf Compare October 31, 2024 12:30
@shahriarlabib000

This comment was marked as resolved.

Sign in to view
@shahriarlabib000 shahriarlabib000 marked this pull request as draft October 31, 2024 13:42
@shahriarlabib000 shahriarlabib000 force-pushed the touchScreen branch 2 times, most recently from 651ef99 to 2c243ae Compare October 31, 2024 15:38
@shahriarlabib000
Copy link
Contributor Author

went thru all this. Just to realize that I wasn't deploying from this branch.
Anyway check it out here: https://shahriarlabib000.github.io/godot-demo-projects/3d/platformer/

@shahriarlabib000 shahriarlabib000 marked this pull request as ready for review October 31, 2024 16:40
@Calinou
Copy link
Member

Calinou commented Nov 3, 2024 •
edited
Loading

"TouchScreen UI" is displayed at all times on desktop:

image

This checkbox should be removed – it should show up based on whether the platform has a touchscreen available (DisplayServer.is_touchscreen_available()).

@shahriarlabib000
Copy link
Contributor Author

shahriarlabib000 commented Nov 4, 2024 •
edited
Loading

But what if they are on a computer which also has a touchScreen? They would probably prefer mouse and keyboard.
Maybe we can show the checkbox to hide the touchScreenUi along with the touchScreenUi?
Or is this what you meant?
While waiting for your response I'll update it like this

@Calinou
Copy link
Member

Calinou commented Nov 4, 2024 •
edited
Loading

But what if they are on a computer which also has a touchScreen?

Godot doesn't support touchscreen events on desktop platforms currently (they're detected as mouse events), so I don't think it makes sense to ever show touch controls on them right now. Besides, playing on a laptop with touch controls is pretty impractical given the form factor.

I don't know any PC game that has a touch controls option.

@shahriarlabib000
Copy link
Contributor Author

shahriarlabib000 commented Nov 4, 2024 •
edited
Loading

Besides, playing on a laptop with touch controls is pretty impractical given the form factor.

I don't know any PC game that has a touch controls option.

Yes, I agree, sorry if I wasn't clear enough.

Godot doesn't support touchscreen events on desktop platforms currently

Oh okay, I'll completely remove it then , thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shahriarlabib000 @Calinou