Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallbacks and mention non-working features when using Compatibility or the Web platform #1132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 13, 2024

  • Make 3D lights with shadows darker when using Compatibility to better match the apperance of Forward+/Mobile, due to the use of sRGB blending for those lights.
  • Silence some warnings when running projects with the Compatibility rendering method, such as the one about 2D MSAA not being supported.
  • Rebake lightmaps in Global Illumination to improve quality and reduce light leaking with improvements from 4.3.
    • Increase probe density for dynamic objects, and mark the moving box as a dynamic object for GI purposes.

This is done to improve the experience with the web-based demos, which always run with the Compatibility rendering method.

Note that the Compatibility rendering method check doesn't use godotengine/godot#85430, as it's only available in 4.4 and demos are deployed to the web on CI using 4.3. We can replace all existing checks in one go once 4.4 is released.

The amount of custom code required could be reduced with godotengine/godot#98656.

Preview

Forward+/Mobile

Forward+/Mobile

Compatibility

Example message about an unsupported feature in the bottom-left corner.

Compatibility

- Make 3D lights with shadows darker when using Compatibility to better
  match the apperance of Forward+/Mobile, due to the use of sRGB blending
  for those lights.
- Silence some warnings when running projects with the Compatibility
  rendering method, such as the one about 2D MSAA not being supported.
- Rebake lightmaps in Global Illumination to improve quality and reduce
  light leaking with improvements from 4.3.
  - Increase probe density for dynamic objects, and mark the moving box
    as a dynamic object for GI purposes.

This is done to improve the experience with the web-based demos,
which always run with the Compatibility rendering method.
@Calinou Calinou changed the title Add fallbacks and mention non-working features when using Compatibility Add fallbacks and mention non-working features when using Compatibility or the Web platform Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant