Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update groups image in saving_games tutorial #10321

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Update groups image in saving_games tutorial #10321

merged 1 commit into from
Nov 26, 2024

Conversation

syntaxerror247
Copy link
Contributor

@syntaxerror247 syntaxerror247 commented Nov 25, 2024 •
edited
Loading

tetrapod00
tetrapod00 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ideally the outlines on UI screenshots should be fffb44 yellow, not red, as specified here (it's easy to miss that guideline in the whole page).

Also this page probably needs a refresh at some point in a later PR. For the purposes of making a group to store persistent objects, a Global Group probably makes a lot more sense? Definitely outside the scope of this PR though.

@tetrapod00 tetrapod00 added bug area:manual Issues and PRs related to the Manual/Tutorials section of the documentation content:images Issues and PRs involving outdated or incorrect images in articles topic:editor Related to editor features or workflows labels Nov 25, 2024
@mhilbrunner mhilbrunner merged commit 14b0433 into godotengine:master Nov 26, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thanks!

@syntaxerror247 syntaxerror247 deleted the patch branch November 26, 2024 05:23
@mhilbrunner
Copy link
Member

Cherrypicked to 4.3 in #10347.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetrapod00 tetrapod00 tetrapod00 approved these changes

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug content:images Issues and PRs involving outdated or incorrect images in articles topic:editor Related to editor features or workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Old node group inspector in "Saving games" documentation
3 participants
@syntaxerror247 @mhilbrunner @tetrapod00