Fix mold instruction for old systems #10336
Open
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetrapod00
added
enhancement
area:contributing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that for old GCC mold linker works kinda differently. You can check it inside godot-4.3-stable/platform/linuxbsd/detect.py in Godot sources.
I don't know why, but it starts to search a certain link in certain paths: "/usr/libexec", "/usr/local/libexec", "/usr/lib" and "/usr/local/lib", otherwise it gives an error.
I think this could be fixed in the code, but since I'm not very knowledgeable and this feature is already there, I preferred to mention it in the documentation. To be sure, users even don't need to add mold/bin folder into PATH, if they are using GCC. But it's necessary for other compilers: for exemple clang gave me an error "invalid linker name in argument '-fuse-ld=mold'", when I deleted mold/bin from PATH. So this requirement I left in documentation page without unnecessary details.
UPD: Forgot to say that I used Godot 4.3 sources.