Document GDScript @export_tool_button
#10338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetrapod00
added
enhancement
topic:gdscript
area:manual
tetrapod00
requested changes
Nov 29, 2024
There was a problem hiding this comment.
This looks great once changes are applied.
I can think of some possible improvements to make in future PRs (to be clear, these do not need to be added to this PR):
- Link to tool script documentation
- Mention that the scene may need to be reloaded for changes to propagate
- Further document what the label and icon parameters do,
- Include a second example with advanced usage.
tetrapod00
approved these changes
Nov 29, 2024
tetrapod00
changed the title
@export_tool_button
dalexeev
reviewed
Nov 29, 2024
dalexeev
approved these changes
Nov 29, 2024
skyace65
approved these changes
Nov 29, 2024
|
Thanks! And congrats on your first merged PR! In the future please try and keep PRs to 1 commit, I did a squash and merge this time so it's fine but keep that in mind for the future. If you don't know how to do that we have a guide here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add @export_tool_button for GDscript to the documention for godotengine/godot#96290 .