Update monochrome android icon instructions #10365
Open
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyace65
added
enhancement
area:manual
syntaxerror247
suggested changes
Dec 4, 2024
| @@ -100,20 +100,18 @@ There are two types of icons required by Godot: | |||
|
|
|||
| - **Main Icon:** The "classic" icon. This will be used on all Android versions up to Android 8 (Oreo), exclusive. Must be at least 192×192 px. | |||
| - **Adaptive Icons:** Starting from Android 8 (inclusive), `Adaptive Icons <https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive>`_ were introduced. Applications will need to include separate background and foreground icons to have a native look. The user's launcher application will control the icon's animation and masking. Must be at least 432×432 px. | |||
| - **Themed Icons:** Starting from Android 13 (inclusive), Themed Icons were introduced. Applications will need to include a monochrome icon to enable this feature. The user's launcher application will control the icon's theme. Must be at least 432×432 px. | |||
There was a problem hiding this comment.
It's better to keep it with other icons. Just add optional here, e.g. Themed Icons (optional)
There was a problem hiding this comment.
The problem is that doesn't read well since the section starts with "There are two types of icons required by Godot:"
There was a problem hiding this comment.
@skyace65 Then we can merge themed icon into Adaptive icon.
**Adaptive Icons:** `Adaptive Icons <https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive>`_ were introduced in Android 8. Applications need to provide separate background and foreground icons to achieve a native look. Themed icons (optional), enabled by providing a monochrome icon, allow launchers to apply the user's chosen theme to the app icon from Android 13 onwards. The user's launcher application controls the icon's animation, masking, and theming based on user preferences. All icons must be at least 432x432 pixels.
Comment on lines
+108
to
+109
| You can also optionally include a Themed Icon. Starting from Android 13 (inclusive), Themed Icons were introduced. Applications will need to include a monochrome icon to enable this feature. The user's launcher application will control the icon's theme. Must be at least 432×432 px. | ||
|
|
There was a problem hiding this comment.
Suggested change
| You can also optionally include a Themed Icon. Starting from Android 13 (inclusive), Themed Icons were introduced. Applications will need to include a monochrome icon to enable this feature. The user's launcher application will control the icon's theme. Must be at least 432×432 px. |
|
|
||
| .. seealso:: It's important to adhere to some rules when designing adaptive icons. `Google Design has provided a nice article <https://medium.com/google-design/designing-adaptive-icons-515af294c783>`_ that helps to understand those rules and some of the capabilities of adaptive icons. | ||
|
|
||
| .. caution:: The most important adaptive icon design rule is to have your icon critical elements inside the safe zone: a centered circle with a diameter of 66dp (264 pixels on ``xxxhdpi``) to avoid being clipped by the launcher. | ||
|
|
||
| You can also optionally include a Themed Icon. Starting from Android 13 (inclusive), Themed Icons were introduced. Applications will need to include a monochrome icon to enable this feature. The user's launcher application will control the icon's theme. Must be at least 432×432 px. | ||
|
|
||
| If you don't provide some of the requested icons, Godot will replace them using a fallback chain, trying the next in line when the current one fails: |
There was a problem hiding this comment.
Suggested change
| If you don't provide some of the requested icons, Godot will replace them using a fallback chain, trying the next in line when the current one fails: | |
| If you don't provide the requested icons (except for Monochrome), Godot will replace them using a fallback chain, trying the next in line when the current one fails: |
|
The original PR was cherrypicked to 4.3 in godotengine/godot#100066, so this can also be cherrypicked to 4.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monochrome icons are no longer mandatory since godotengine/godot#99378 was merged.