Clarify sentence in Overview of Godot's key concepts #10371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetrapod00
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Mild approval. This was discussed in RC, and a couple people thought that the existing version was a bit confusing. I agreed and suggested that OP make a PR for it.
It's worth nothing that this is a small, subjective change, and often wouldn't be worth breaking translations for. But OP is also translating the docs which is how they noticed this at all, so I think it's fine in this case.
tetrapod00
added
enhancement
area:getting started
tetrapod00
changed the title
mhilbrunner
approved these changes
Dec 6, 2024
|
Merged. Thanks and congrats on your first merged contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to understand