-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note on Quest3, how to pick renderer, how to contribute to docs #10375
base: 4.3
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! It looks like you're making changes against 4.3
instead of master
, probably because you used the "Edit on GitHub" button? PRs should be made against master
, see here. (Unfortunately our "Edit on GitHub" links still link to 4.3
).
I'd recommend remaking this PR targeting master
instead, since one of your changes was actually addressed with a new page in the master/latest version.
What renderer should I use? | ||
--------------------------- | ||
|
||
To choose Renderer when making a new project, see: :ref:`doc_internal_rendering_architecture` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should check the latest version of this page 🙂
@@ -622,7 +628,8 @@ for the rest of the game. | |||
How can I support Godot development or contribute? | |||
-------------------------------------------------- | |||
|
|||
See :ref:`doc_ways_to_contribute`. | |||
See :ref:`doc_ways_to_contribute`, or click "Edit on GitHub" on the top-right to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not against this kind of call to action to edit the docs directly, but it's probably better suited to be on the page itself, not in the FAQ linking to the page.
@@ -44,15 +44,15 @@ Which platforms are supported by Godot? | |||
* Windows | |||
* macOS | |||
* Linux, \*BSD | |||
* Android (experimental) | |||
* Android (experimental, including Meta Quest 3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still seems valid in latest.
* `Web <https://editor.godotengine.org/>`__ (experimental) | ||
|
||
**For exporting your games:** | ||
|
||
* Windows | ||
* macOS | ||
* Linux, \*BSD | ||
* Android | ||
* Android (including Meta Quest 3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we should be singling out specific devices here, you can export and run XR projects on other Android based headsets like the Pico and Lynx R1. And listing every one wouldn't look great and add an extra maintenance burden. I think it's probably best to say "(including XR devices)"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think it's somewhat reasonable to single out Meta Quest devices for the XR editor, since that seems to be the scope of current support. But for exported projects we shouldn't be this specific.
Also, this kind of narrow specification is prone to become out of date, so just "including XR devices" for both the editor and exports also seems fine to me.
No description provided.