Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"first 2D game" - minor additions, clarification when areas of the editor are first mentioned #10378

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

LDMLN
Copy link
Contributor

@LDMLN LDMLN commented Dec 6, 2024

Addresses #10291
First attempted pr so wanted to start small. These are some of the areas that I saw a friend (completely new to Godot) get slightly hung up on so I thought I would try and add some clarifying remarks. I mentioned this in an issue I opened a week or so ago.
Please let me know if there are any changes I can make to this or if I've made some mistake.

@Calinou Calinou added enhancement area:getting started Issues and PRs related to the Getting Started section of the documentation cherrypick:4.3 labels Dec 6, 2024
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think overall this is a good addition to reduce some confusion.

I made some suggestions for formatting, and to use some standard terminology that we use for describing the editor.


(As a side note, for other reviewers, this page uses very different formatting for describing the editor than the one we're slowly standardizing on, using quotes for describing UI rather than bold, and apparently using somewhat nonstandard terms for editor UI. Just pointing it out for future reference.)

getting_started/first_2d_game/01.project_setup.rst Outdated Show resolved Hide resolved
getting_started/first_2d_game/02.player_scene.rst Outdated Show resolved Hide resolved
getting_started/first_2d_game/02.player_scene.rst Outdated Show resolved Hide resolved
@mhilbrunner mhilbrunner merged commit c01bcad into godotengine:master Jan 3, 2025
@mhilbrunner
Copy link
Member

Merged. Thanks and congrats on your first merged contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:getting started Issues and PRs related to the Getting Started section of the documentation cherrypick:4.3 enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants