Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIME is affected by time_scale #10386

Merged
merged 1 commit into from
Dec 9, 2024
Merged

TIME is affected by time_scale #10386

merged 1 commit into from
Dec 9, 2024

Conversation

Ryan-000
Copy link
Contributor

@Ryan-000 Ryan-000 commented Dec 8, 2024

Update docs to say that TIME is affected by time_scale.

tetrapod00
tetrapod00 approved these changes Dec 8, 2024
View reviewed changes
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I guess this changed since the original description was written in 3.x.

I experimentally checked this with a simple test script, and it does indeed seem to be affected by time_scale but not by pausing.

tutorials/shaders/shader_reference/spatial_shader.rst Show resolved Hide resolved
@tetrapod00 tetrapod00 added the area:manual Issues and PRs related to the Manual/Tutorials section of the documentation label Dec 8, 2024
@mhilbrunner mhilbrunner merged commit 74b354e into godotengine:master Dec 9, 2024
1 check passed
@mhilbrunner
Copy link
Member

Merged. Thanks and congrats on your first merged contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetrapod00 tetrapod00 tetrapod00 approved these changes

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug cherrypick:4.3 topic:shaders
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ryan-000 @mhilbrunner @tetrapod00