Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI updates (master branch) #10474

Merged
merged 7 commits into from
Jan 7, 2025
Merged

Conversation

mhilbrunner
Copy link
Member

@mhilbrunner mhilbrunner commented Jan 6, 2025

Happy 2025! Time for some spring cleaning in the new year:

  • Update from Ubuntu 22.04 to 24.04 (and replace all use of ubuntu-latest with 24.04 for consistency)
    • Update workflows to use Python venvs, as newer Ubuntu (and Debian) versions don't want us trashing global packages with Python packages (see here)
      • Using virtualenvs also means we now need to exclude directories starting with . from Sphinx builds, to support .venv (this would have been a good idea anyway, for .git, .vscode and so on)
  • Fix permission issues (by adding write permissions to repo contents and/or PRs where those are now needed, see here, originally added around 2021, now mandatory), this should hopefully fix the issues with Add GitHub Action to automatically create cherrypick PRs #10361)
  • (Hopefully) improve CI build times by utilizing up to 4 CPUs (which according to docs seems now save to assume for Github action runners)
  • Change all references to github.ref to github.ref_name, which should be equivalent to the old behaviour (see here)
  • Set timeouts (by default, Github waits 6 hours before killing a hung job, whereas all our stuff should be killed with fire way earlier, most take a few minutes a most, with building the offline docs being the longest at 1-2 hours, not 6)
  • Update some comments that have grown old by now

@mhilbrunner mhilbrunner added bug enhancement github_actions Pull requests that update GitHub Actions code labels Jan 6, 2025
@mhilbrunner mhilbrunner force-pushed the ci-updates branch 3 times, most recently from c2c5443 to 86d23b1 Compare January 6, 2025 17:48
@mhilbrunner mhilbrunner marked this pull request as draft January 6, 2025 17:51
@mhilbrunner mhilbrunner force-pushed the ci-updates branch 2 times, most recently from 30046d6 to aef59de Compare January 6, 2025 18:24
@mhilbrunner mhilbrunner marked this pull request as ready for review January 6, 2025 18:25
@mhilbrunner mhilbrunner merged commit 30f46c8 into godotengine:master Jan 7, 2025
1 check passed
@mhilbrunner
Copy link
Member Author

Let's see if anything breaks, all tests so far seem good 👀 Merging, as I want to do further work on GH actions and this needs to go in first... thanks for having a look, tetra!

@mhilbrunner mhilbrunner deleted the ci-updates branch January 7, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants