SCons: Fix MSVC bypassing disabled warnings #100185
Merged
+56
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Dec 9, 2024
| self["CFLAGS"] = [x for x in self["CFLAGS"] if not (x.startswith("/W") or x.startswith("/w"))] | ||
| self["CXXFLAGS"] = [x for x in self["CXXFLAGS"] if not (x.startswith("/W") or x.startswith("/w"))] | ||
| WARN_FLAGS = ["/Wall", "/W4", "/W3", "/W2", "/W1", "/W0"] | ||
| self["CCFLAGS"] = [x for x in self["CCFLAGS"] if x not in WARN_FLAGS] |
There was a problem hiding this comment.
Won't this lead to warnings if you have all the disabled_warnings from SCons + /w?
MSVC seems to be really finicky about having any kind of conflicting or double specification of expected behavior.
There was a problem hiding this comment.
Surprisingly, no! The conflict warnings only crop up for the main overrides; individual warnings & even warn-as-error can still be passed without issue
akien-mga
reviewed
Dec 9, 2024
Repiteo
force-pushed
the
scons/fix-thirdparty-warnings
branch
from
f96a400 to
070aeb5
Compare
akien-mga
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging #94321 exposed a bug in our SCons setup on MSVC: some warnings persist even when they should've been disabled via
/w. Technically, this is more of an MSVC bug, but this was fixed by implementing these two changes:disable_warningsare the flags that change the overall warning scopewarning=nois passed, ensure that/wd4267is explicitly appended alongside/wThis includes a few other changes that were integrated while getting to the bottom of this, as they were tangentally related:
csgmodule now correctly rebuilds itself if third-party libraries changedisable_warningsfunctions to their main equivalent