Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind new core METHOD_FLAG_VIRTUAL_REQUIRED bitfield #103302

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Feb 25, 2025

This new constant was added in PR #93311, but it wasn't bound, which means it won't be added to extension_api.json, so GDExtensions won't see it.

This was my mistake! (The 2nd one I've found today - sorry!)

I noticed this when trying to implement the equivalent changes in godot-cpp in PR godotengine/godot-cpp#1719, but the constant was missing.

Given that this is needed to allow godot-cpp's GDVIRTUAL*() macros match those in Godot 4.4, I'd really love to get this into 4.4, but it's not the end of the world if it needs to wait for 4.4.1.

@akien-mga akien-mga merged commit bb634fd into godotengine:master Feb 25, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants