Fix internal events not being delivered to some Window types #81243
+22
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sauermann
force-pushed
the
fix-window-events
branch
from
d2ee4eb to
04021b3
Compare
|
Tested on top of master and it doesn't seem to fix the linked problem. |
|
Thanks for testing. Then I will need to check out, what has changed in the meantime. |
|
Please note, that this PR doesn't fix the Gui in 3D Demo in the master branch of the demo-projects repository, but the Gui in 3D Demo of the PR godotengine/godot-demo-projects#925. I have checked again and this PR still works for me. |
|
Ok sorry, I thought the issue is more generic and the demo changes are unrelated. |
KoBeWi
reviewed
Nov 10, 2023
KoBeWi
approved these changes
Nov 13, 2023
`AcceptDialog`, `Popup` and `PopupMenu` no longer subscribe to "window_input" signal, because that is only sent if it is not an internal signal. Instead they receive events in `_input_from_window`. They ensure that the event is also propagated to their super-function, just like previously the signals would be treated.
Sauermann
force-pushed
the
fix-window-events
branch
from
04021b3 to
fa02d19
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix comment godotengine/godot-demo-projects#925 (comment) for the Gui in 3D Demo of godotengine/godot-demo-projects#925 (it doesn't fix the issue for the Demo in current master of the demo-projects repository).
part of #77189
AcceptDialog,PopupandPopupMenuno longer subscribe to "window_input" signal, because that is only sent if it is not an internal signal.Instead they receive events in
_input_from_window. They ensure that the event is also propagated to their super-function, just like previously the signals would be treated.Updated 2023-09-12: Fix merge conflict