[Shaders] Disallow trailing commas in function declarations #87075
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:shaders
cherrypick:4.1
AThousandShips
commented
Jan 11, 2024
| #ifdef DISABLE_DEPRECATED | ||
| // Disallow trailing comma. | ||
| if (tk.type == TK_PARENTHESIS_CLOSE) { | ||
| _set_error(RTR("Expected a valid data type for argument.")); |
There was a problem hiding this comment.
Picked this error as it matches what happens if you do void foo(,)
There was a problem hiding this comment.
Would a more user-friendly error be better, though? E.g. "(Remove the trailing comma?)"
There was a problem hiding this comment.
Could add 🙂 considering a warning as well so working on the wording, thank you!
AThousandShips
removed
cherrypick:4.1
|
Tested and it doesn't look good and isn't noticeable, also feels like a bad idea to add a new warning category just for this to allow it to be configured well |
AThousandShips
force-pushed
the
shader_fix
branch
from
2d211f1
to
2c0abaf
Compare
AThousandShips
changed the title
AThousandShips
changed the title
AThousandShips
force-pushed
the
shader_fix
branch
from
2c0abaf
to
46e1b34
Compare
AThousandShips
force-pushed
the
shader_fix
branch
from
46e1b34
to
94165e5
Compare
AThousandShips
force-pushed
the
shader_fix
branch
from
94165e5
to
39acc83
Compare
AThousandShips
force-pushed
the
shader_fix
branch
from
39acc83
to
706b910
Compare
AThousandShips
force-pushed
the
shader_fix
branch
from
706b910
to
65ec7a0
Compare
AThousandShips
force-pushed
the
shader_fix
branch
from
65ec7a0
to
6b8c867
Compare
AThousandShips
force-pushed
the
shader_fix
branch
from
6b8c867
to
eec6ed5
Compare
AThousandShips
force-pushed
the
shader_fix
branch
2 times, most recently
from
328a4ae
to
22db465
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might not be the most elegant fix, but not very familiar with this code, if someone has a cleaner idea for doing this I'd appreciate suggestions. Added it with deprecation to avoid breaking existing shaders, though I'm not sure that's necessary
I was considering enclosing the whole
whileloop in a block to check closing paren at the start, which would make catching this easier, but want to avoid noise in the blame if I can, having to indent the whole thing.For reasoning, see the discussion in:
Alternative to: