-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a project setting to control 3D line drawing thickness #91171
base: master
Are you sure you want to change the base?
Add a project setting to control 3D line drawing thickness #91171
Conversation
0e83f13
to
4f7b641
Compare
If we want to expose this for GPUs that support it, we need to check for the From the Vulkan spec:
|
4f7b641
to
250abdd
Compare
Rebased and tested again, it works as expected. Note that I didn't implement the
I can see
The question is, how do I expose this information so it can be read in RenderSceneClustered and RenderSceneMobile? Preferably without adding Vulkan-specific checks to those classes, that is. (Also, what about Direct3D 12? I suppose nearly all GPUs on D3D12 support line widths greater than |
250abdd
to
01c53c0
Compare
Either through |
This setting affects all lines drawn in 3D, including gizmos in the editor and debug draw options. This can be used to make debug drawing more visible, particularly when using a high-resolution viewport. This relies on hardware support, so it's not available on all platforms and GPUs. It's also only supported in the Forward+ and Mobile rendering methods.
01c53c0
to
d5c7104
Compare
Thanks @myaaaaaaaaa for the original implementation 🙂
This setting affects all lines drawn in 3D, including gizmos in the editor and debug draw options. This can be used to make debug drawing more visible, particularly when using a high-resolution viewport.
This relies on hardware support, so it's not available on all platforms and GPUs (see maximum supported line width). It's also only supported in the Forward+ and Mobile rendering methods.
This could technically be implemented in Compatibility with
glLineWidth()
(on desktop platforms only), but I haven't managed to do this yet.Preview
Line width = 1
Line width = 2
Line width = 1 with half-resolution viewport
Effective line width is identical to line width = 2. This shows how thicker lines are helpful on high-resolution viewports, such as hiDPI displays.
TODO