Reduce opacity of nodes with no shared transition when selecting an AnimationNodeStateMachine node #98402
+174
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
|
In my last commit, I made it so that when a pair of transitions exist, selecting one also highlights the other.
|
|
I'll bring this to the Godot Engine animation meeting later this week to review. |
SaracenOne
approved these changes
Dec 1, 2024
vaner-org
force-pushed
the
highlight-node-neighbours
branch
2 times, most recently
from
136d2b9
to
9af680d
Compare
|
All done, ready for you. |
…nimationNodeStateMachine node Applied suggestions from code review
vaner-org
force-pushed
the
highlight-node-neighbours
branch
from
4108fd7
to
366fa9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to help visibility when working with complex
AnimationNodeStateMachinecases.This PR is a companion to 98401, which makes the selection of overlapping transition lines unambiguous.
highlight-selected-neighbours.mp4
As this is my second PR, criticism and feedback would be very much appreciated. I was a bit clueless on header organization and function placement so please let me know what I did wrong.