Clean up slightly how tags are parsed in built-in docs generation #99880
+24
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By defining what the tag's name is early we can avoid a some redundant checks for prefixes.
I don't really expect this to be much of a performance improvement. Perhaps @dalexeev is interested in this, too?
Draft because, perhaps there's more to be done? I wanted to standardize parsing a corresponding value (what comes after
=if it exists), but it's not any faster than, for example,tag.substr(5), which is done everywhere now.Same goes for additional options. It'd be a waste to fetch them early every time.