Improve misleading GDScript parser error #99887
Open
+21
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackErb
changed the title
JackErb
force-pushed
the
gdscript-parser-error-fix
branch
from
1b8b688
to
52110ab
Compare
dalexeev
reviewed
Dec 1, 2024
modules/gdscript/gdscript_parser.cpp
Outdated
| advance(); | ||
| push_error(vformat(R"(Unexpected "%s" in class body.)", previous.source)); |
There was a problem hiding this comment.
Using the token source code in the error message is debatable, since tokens can be multiline or unreadable (LITERAL, NEWLINE, INDENT, DEDENT). I think we should use something like:
const String token_name = previous.is_identifier() ? previous.get_identifier() : previous.get_name();Or maybe add a new method to GDScriptTokenizer::Token.
There was a problem hiding this comment.
Removed this change and made a new test to verify it's on the proper line.
This parser error was misleading. Fixes: 1. Now points at correct line 2. Now prints out the raw token source (e.g. "variable_name" instead of "<Identifier>")
JackErb
force-pushed
the
gdscript-parser-error-fix
branch
from
52110ab
to
b04497c
Compare
Verified it fixes #96792 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parser error was misleading.
Fixes:
====
With Change:
Without Change (misleading):