C#: Fix warnings caught by new problem-matchers #99902
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Restore MSVC problem matcher for Linux builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The above PR integrated specialized problem matchers for our repo, serving as enhanced versions of the ones we were already using. One consequence of this addition was the .NET solutions started to produce warnings as well, so those specific matchers needed to be excluded so they wouldn't create noise on all Actions post-merge. This PR fixes the handful of remaining warnings throughout the C# codebase, allowing that exclusion to be removed so future C# errors/warnings will be caught by GitHub Actions