-
-
Notifications
You must be signed in to change notification settings - Fork 21.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C#: Fix warnings caught by new problem-matchers #99902
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
06b771c
to
86fb3e6
Compare
raulsntos
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine. I checked the generated bindings and these were the only changes:
diff --git a/GodotSharp/GodotObjects/EngineDebugger.cs b/GodotSharp/GodotObjects/EngineDebugger.cs
index 8fe54b1..b61f089 100644
--- a/GodotSharp/GodotObjects/EngineDebugger.cs
+++ b/GodotSharp/GodotObjects/EngineDebugger.cs
@@ -101,7 +101,7 @@ public static partial class EngineDebugger
/// <summary>
/// <para>Registers a message capture with given <paramref name="name"/>. If <paramref name="name"/> is "my_message" then messages starting with "my_message:" will be called with the given callable.</para>
/// <para>The callable must accept a message string and a data array as argument. The callable should return <see langword="true"/> if the message is recognized.</para>
- /// <para><b>Note:</b> The callable will receive the message with the prefix stripped, unlike <see cref="Godot.EditorDebuggerPlugin._Capture(string, Godot.Collections.Array, int)"/>. See the <c>EditorDebuggerPlugin</c> description for an example.</para>
+ /// <para><b>Note:</b> The callable will receive the message with the prefix stripped, unlike <c>EditorDebuggerPlugin._Capture</c>. See the <c>EditorDebuggerPlugin</c> description for an example.</para>
/// </summary>
public static void RegisterMessageCapture(StringName name, Callable callable)
{
diff --git a/GodotSharp/GodotObjects/EngineDebuggerInstance.cs b/GodotSharp/GodotObjects/EngineDebuggerInstance.cs
index e52d2f6..b16c9c4 100644
--- a/GodotSharp/GodotObjects/EngineDebuggerInstance.cs
+++ b/GodotSharp/GodotObjects/EngineDebuggerInstance.cs
@@ -118,7 +118,7 @@ public partial class EngineDebuggerInstance : GodotObject
/// <summary>
/// <para>Registers a message capture with given <paramref name="name"/>. If <paramref name="name"/> is "my_message" then messages starting with "my_message:" will be called with the given callable.</para>
/// <para>The callable must accept a message string and a data array as argument. The callable should return <see langword="true"/> if the message is recognized.</para>
- /// <para><b>Note:</b> The callable will receive the message with the prefix stripped, unlike <see cref="Godot.EditorDebuggerPlugin._Capture(string, Godot.Collections.Array, int)"/>. See the <c>EditorDebuggerPlugin</c> description for an example.</para>
+ /// <para><b>Note:</b> The callable will receive the message with the prefix stripped, unlike <c>EditorDebuggerPlugin._Capture</c>. See the <c>EditorDebuggerPlugin</c> description for an example.</para>
/// </summary>
public void RegisterMessageCapture(StringName name, Callable callable)
{
diff --git a/GodotSharp/GodotObjects/GltfAccessor.cs b/GodotSharp/GodotObjects/GltfAccessor.cs
index 15ab651..27b543f 100644
--- a/GodotSharp/GodotObjects/GltfAccessor.cs
+++ b/GodotSharp/GodotObjects/GltfAccessor.cs
@@ -461,7 +461,7 @@ public partial class GltfAccessor : Resource
private static readonly IntPtr MethodBind12 = ClassDB_get_method_with_compatibility(NativeName, MethodName.GetType, 2455072627ul);
[EditorBrowsable(EditorBrowsableState.Never)]
- public int GetType()
+ public new int GetType()
{
return NativeCalls.godot_icall_0_37(MethodBind12, GodotObject.GetPtr(this));
}
@@ -793,7 +793,7 @@ public partial class GltfAccessor : Resource
/// <summary>
/// Cached name for the 'get_type' method.
/// </summary>
- public static readonly StringName GetType = "get_type";
+ public static new readonly StringName GetType = "get_type";
/// <summary>
/// Cached name for the 'set_type' method.
/// </summary>
diff --git a/GodotSharp/GodotObjects/VisualShaderNodeReroute.cs b/GodotSharp/GodotObjects/VisualShaderNodeReroute.cs
index a1c19f1..537edda 100644
--- a/GodotSharp/GodotObjects/VisualShaderNodeReroute.cs
+++ b/GodotSharp/GodotObjects/VisualShaderNodeReroute.cs
@@ -12,7 +12,7 @@ using Godot.NativeInterop;
public partial class VisualShaderNodeReroute : VisualShaderNode
{
[EditorBrowsable(EditorBrowsableState.Never)]
- public VisualShaderNode.PortType PortType
+ public new VisualShaderNode.PortType PortType
{
get
{
• Restore MSVC problem matcher for Linux builds
86fb3e6
to
57d08db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The above PR integrated specialized problem matchers for our repo, serving as enhanced versions of the ones we were already using. One consequence of this addition was the .NET solutions started to produce warnings as well, so those specific matchers needed to be excluded so they wouldn't create noise on all Actions post-merge. This PR fixes the handful of remaining warnings throughout the C# codebase, allowing that exclusion to be removed so future C# errors/warnings will be caught by GitHub Actions