Metal: Ensure texture_create_from_extension returns correct pixel format
#99905
+19
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
The change looks good, I do wonder if we should validate the other parameters somehow to catch any issues but I think that is overkill.
Haven't been able to reproduce the OpenXR extension working on my Macbook Air but I am assuming that is an issue with the OpenXR PR, not with this. So I suggest this is merged ASAP.
stuartcarnie
force-pushed
the
fix_external_texture
branch
from
5f6f02f
to
7caa039
Compare
stuartcarnie
added a commit
to stuartcarnie/godot
that referenced
this pull request
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior implementation was ignoring the pixel format and returning the same texture.
Helps #98872