Skip to content

Commit

Permalink
fix: issue with !is_inside_tree() when starting editor
Browse files Browse the repository at this point in the history
  • Loading branch information
nmerget committed Sep 17, 2024
1 parent 83670ad commit 69b3812
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@
.vscode
.idea
/site
venv
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ As a maintainer you are able to create a new release.
3. Select target ``master``
4. Click ``Generate release notes``
5. (Optional) You can edit the generated release notes
6. Add a release title in the format ``[Godot_Version]-[Tag]-alpha-[Year][Month][Day]`` as an example ``4.1-v0.0.17-alpha-20231003``
6. Add a release title in the format ``[Tag]-alpha-[Year][Month][Day]`` as an example ``v0.0.17-alpha-20231003``. The used godot version will be added ass prefix automatically
7. Press ``Publish release``

2 changes: 0 additions & 2 deletions editor/editor_tools.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ JavaScriptPlugin::JavaScriptPlugin(EditorNode *p_node) {
declaration_file_dialog->set_file_mode(EditorFileDialog::FILE_MODE_SAVE_FILE);
declaration_file_dialog->set_access(EditorFileDialog::ACCESS_FILESYSTEM);
declaration_file_dialog->add_filter(TTR("*.d.ts;TypeScript Declaration file"));
declaration_file_dialog->set_current_file("godot.d.ts");
declaration_file_dialog->connect("file_selected", callable_mp(this, &JavaScriptPlugin::_export_typescript_declare_file));
EditorNode::get_singleton()->get_gui_base()->add_child(declaration_file_dialog);

Expand All @@ -89,7 +88,6 @@ JavaScriptPlugin::JavaScriptPlugin(EditorNode *p_node) {
enumberation_file_dialog->set_file_mode(EditorFileDialog::FILE_MODE_SAVE_FILE);
enumberation_file_dialog->set_access(EditorFileDialog::ACCESS_FILESYSTEM);
enumberation_file_dialog->add_filter(TTR("*.mjs;JavaScript file"));
enumberation_file_dialog->set_current_file("enumerations.mjs");
enumberation_file_dialog->connect("file_selected", callable_mp(this, &JavaScriptPlugin::_export_enumeration_binding_file));
EditorNode::get_singleton()->get_gui_base()->add_child(enumberation_file_dialog);

Expand Down

0 comments on commit 69b3812

Please sign in to comment.