refactoring(oracle): rename watch_point -> spy_point (watch_point nam…

…e clashes with watchpoints)

src/debugger/mod.rs

@@ -517,8 +517,8 @@ impl Debugger {
                                 let oracles = self.oracles.clone();
                                 let ready_oracles = oracles.into_values().filter(|(_, a)| *a);
                                 for (oracle, _) in ready_oracles {
-                                    let watch_points = oracle.watch_points();
-                                    for request in watch_points {
+                                    let spy_points = oracle.spy_points();
+                                    for request in spy_points {
                                         weak_error!(self.set_transparent_breakpoint(request));
                                     }
                                 }

src/oracle/builtin/nop.rs

@@ -40,7 +40,7 @@ impl Oracle for NopOracle {
         true
     }
 
-    fn watch_points(self: Arc<Self>) -> Vec<CreateTransparentBreakpointRequest> {
+    fn spy_points(self: Arc<Self>) -> Vec<CreateTransparentBreakpointRequest> {
         vec![]
     }
 }

src/oracle/builtin/tokio.rs

@@ -183,7 +183,7 @@ impl Oracle for TokioOracle {
         true
     }
 
-    fn watch_points(self: Arc<Self>) -> Vec<CreateTransparentBreakpointRequest> {
+    fn spy_points(self: Arc<Self>) -> Vec<CreateTransparentBreakpointRequest> {
         let oracle = self.clone();
         let poll_handler = move |dbg: &mut Debugger| {
             if let Err(e) = oracle.on_poll(dbg) {

src/oracle/mod.rs

@@ -49,10 +49,7 @@ pub trait Oracle: ConsolePlugin + TuiPlugin {
     /// * `dbg`: debugger instance
     fn ready_for_install(&self, dbg: &Debugger) -> bool;
 
-    /// A list of watch_point using by oracle.
-    /// In debugger watch point implemented by transparent breakpoints.
-    ///
-    /// FIXME now oracle `watchpoint` name clashes with debugger watchpoint (data breakpoint).
-    /// Let's rename it.
-    fn watch_points(self: Arc<Self>) -> Vec<CreateTransparentBreakpointRequest>;
+    /// A list of spy-points using by oracle.
+    /// In debugger spy-point implemented by transparent breakpoints.
+    fn spy_points(self: Arc<Self>) -> Vec<CreateTransparentBreakpointRequest>;
 }