snk and assembly sign

goenning · Sep 14, 2015 · 7bcf930 · 7bcf930
1 parent 04e2a10
commit 7bcf930
Show file tree

Hide file tree

Showing 10 changed files with 48 additions and 4 deletions.
diff --git a/SharpSapRfc.sln b/SharpSapRfc.sln
@@ -1,7 +1,7 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio 2013
-VisualStudioVersion = 12.0.21005.1
+VisualStudioVersion = 12.0.40629.0
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "SharpSapRfc.Test", "tests\SharpSapRfc.Test.csproj", "{37086A57-834D-4ACC-B922-CE3ADA4B9F31}"
 EndProject

diff --git a/sharpsaprfc.snk b/sharpsaprfc.snk
diff --git a/src/base/SharpSapRfc.csproj b/src/base/SharpSapRfc.csproj
@@ -68,6 +68,15 @@
     <ErrorReport>prompt</ErrorReport>
     <CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
   </PropertyGroup>
+  <PropertyGroup>
+    <SignAssembly>true</SignAssembly>
+  </PropertyGroup>
+  <PropertyGroup>
+    <AssemblyOriginatorKeyFile>..\..\sharpsaprfc.snk</AssemblyOriginatorKeyFile>
+  </PropertyGroup>
+  <PropertyGroup>
+    <DelaySign>false</DelaySign>
+  </PropertyGroup>
   <ItemGroup>
     <Reference Include="System" />
     <Reference Include="System.Data" />
@@ -105,6 +114,9 @@
     <Compile Include="Structure\Tab512.cs" />
   </ItemGroup>
   <ItemGroup>
+    <None Include="..\..\sharpsaprfc.snk">
+      <Link>sharpsaprfc.snk</Link>
+    </None>
     <None Include="packages.config" />
   </ItemGroup>
   <ItemGroup />

diff --git a/src/plain/PlainRfcValueMapper.cs b/src/plain/PlainRfcValueMapper.cs
@@ -1,12 +1,13 @@
 using System.Globalization;
+using System.Threading;
 
 namespace SharpSapRfc.Plain
 {
     public class PlainRfcValueMapper : RfcValueMapper
     {
         protected override NumberFormatInfo GetNumberFormat()
         {
-            return this.CommaDecimalNumberFormat;
+            return Thread.CurrentThread.CurrentCulture.NumberFormat;
         }
     }
 }
diff --git a/src/plain/SharpSapRfc.Plain.csproj b/src/plain/SharpSapRfc.Plain.csproj
@@ -65,6 +65,12 @@
     <ErrorReport>prompt</ErrorReport>
     <CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
   </PropertyGroup>
+  <PropertyGroup>
+    <SignAssembly>true</SignAssembly>
+  </PropertyGroup>
+  <PropertyGroup>
+    <AssemblyOriginatorKeyFile>..\..\sharpsaprfc.snk</AssemblyOriginatorKeyFile>
+  </PropertyGroup>
   <ItemGroup>
     <Reference Include="System" />
     <Reference Include="System.Core" />
@@ -107,6 +113,11 @@
       <Name>SharpSapRfc</Name>
     </ProjectReference>
   </ItemGroup>
+  <ItemGroup>
+    <None Include="..\..\sharpsaprfc.snk">
+      <Link>sharpsaprfc.snk</Link>
+    </None>
+  </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
        Other similar extension points exist, see Microsoft.Common.targets.

diff --git a/src/soap/SharpSapRfc.Soap.csproj b/src/soap/SharpSapRfc.Soap.csproj
@@ -47,6 +47,12 @@
     <ErrorReport>prompt</ErrorReport>
     <CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
   </PropertyGroup>
+  <PropertyGroup>
+    <SignAssembly>true</SignAssembly>
+  </PropertyGroup>
+  <PropertyGroup>
+    <AssemblyOriginatorKeyFile>..\..\sharpsaprfc.snk</AssemblyOriginatorKeyFile>
+  </PropertyGroup>
   <ItemGroup>
     <Reference Include="System" />
     <Reference Include="System.configuration" />
@@ -75,6 +81,11 @@
       <Name>SharpSapRfc</Name>
     </ProjectReference>
   </ItemGroup>
+  <ItemGroup>
+    <None Include="..\..\sharpsaprfc.snk">
+      <Link>sharpsaprfc.snk</Link>
+    </None>
+  </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
        Other similar extension points exist, see Microsoft.Common.targets.

diff --git a/tests/Mapper/AbapValueMapperToRemoteTestData.cs b/tests/Mapper/AbapValueMapperToRemoteTestData.cs
@@ -26,7 +26,7 @@ public class Plain_AbapValueMapperToRemoteTestData : AbapValueMapperToRemoteTest
         protected override List<object[]> AdditionalTestData()
         {
             return new List<object[]> { 
-                 new object[] { "56,2", AbapDataType.DECIMAL, 56.2m },
+                 new object[] { "56.2", AbapDataType.DECIMAL, 56.2m },
             };
         }
     }

diff --git a/tests/SharpSapRfc.Test.csproj b/tests/SharpSapRfc.Test.csproj
@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <Import Project="..\packages\xunit.runner.visualstudio.2.0.1\build\net20\xunit.runner.visualstudio.props" Condition="Exists('..\packages\xunit.runner.visualstudio.2.0.1\build\net20\xunit.runner.visualstudio.props')" />
   <PropertyGroup>
     <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
     <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
@@ -17,6 +18,7 @@
     <IsCodedUITest>False</IsCodedUITest>
     <TestProjectType>UnitTest</TestProjectType>
     <TargetFrameworkProfile />
+    <NuGetPackageImportStamp>efb2a340</NuGetPackageImportStamp>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
     <DebugSymbols>true</DebugSymbols>
@@ -189,6 +191,12 @@
   </Choose>
   <Import Project="$(VSToolsPath)\TeamTest\Microsoft.TestTools.targets" Condition="Exists('$(VSToolsPath)\TeamTest\Microsoft.TestTools.targets')" />
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
+  <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
+    <PropertyGroup>
+      <ErrorText>This project references NuGet package(s) that are missing on this computer. Enable NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
+    </PropertyGroup>
+    <Error Condition="!Exists('..\packages\xunit.runner.visualstudio.2.0.1\build\net20\xunit.runner.visualstudio.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\xunit.runner.visualstudio.2.0.1\build\net20\xunit.runner.visualstudio.props'))" />
+  </Target>
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
        Other similar extension points exist, see Microsoft.Common.targets.
   <Target Name="BeforeBuild">

diff --git a/tests/TestCases/Soap_ExceptionDetailsTestCase.cs b/tests/TestCases/Soap_ExceptionDetailsTestCase.cs
@@ -30,7 +30,7 @@ protected override SapRfcConnection GetConnection()
 
         protected override string GetExpectedRequestBody()
         {
-            return @"FUNCTION Z_SSRT_DIVIDE (EXPORT PARAMETER E_QUOTIENT=0,00, EXPORT PARAMETER E_REMAINDER=0, IMPORT PARAMETER I_NUM1=2,00, IMPORT PARAMETER I_NUM2=0,00)";
+            return @"FUNCTION Z_SSRT_DIVIDE (EXPORT PARAMETER E_QUOTIENT=0.00, EXPORT PARAMETER E_REMAINDER=0, IMPORT PARAMETER I_NUM1=2.00, IMPORT PARAMETER I_NUM2=0.00)";
         }
     }
 

diff --git a/tests/packages.config b/tests/packages.config
@@ -3,4 +3,5 @@
   <package id="SAPNCo.x86" version="3.0.13.1" targetFramework="net40" />
   <package id="xunit" version="1.9.2" targetFramework="net40" />
   <package id="xunit.extensions" version="1.9.2" targetFramework="net40" />
+  <package id="xunit.runner.visualstudio" version="2.0.1" targetFramework="net40" />
 </packages>
-Original file line number
+Diff line change
@@ Expand Up / @@ -30,7 +30,7 @@ protected override SapRfcConnection GetConnection() @@
             protected override string GetExpectedRequestBody()
             {
-                return @"FUNCTION Z_SSRT_DIVIDE (EXPORT PARAMETER E_QUOTIENT=0,00, EXPORT PARAMETER E_REMAINDER=0, IMPORT PARAMETER I_NUM1=2,00, IMPORT PARAMETER I_NUM2=0,00)";
+                return @"FUNCTION Z_SSRT_DIVIDE (EXPORT PARAMETER E_QUOTIENT=0.00, EXPORT PARAMETER E_REMAINDER=0, IMPORT PARAMETER I_NUM1=2.00, IMPORT PARAMETER I_NUM2=0.00)";
             }
         }
@@ Expand Down @@