Major refactor of #chef_role and #chef_search and ChefZero tests #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade chef and capistrano gems * Refactor #chef_role so that normal and block based querying work * Better support for customization via dependency injecting Search class * chef-zero backed test units and environment * Proper Gemfile and Rakefile * Rake::TestTask verbosity is optional
|
Oh noez! We don't want Travis failing now do we. :) I'll have to look into what I can change on my end to get it working. |
|
|
|
Actually the #role call I'm making doesn't work the same in Capistrano 3 and I've got a fix coming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes major refactoring and testing of #chef_role and #chef_search. It also resolves issue #25.
Specifically (from commit message)...
Now that I see PR #27 it would also fit perfectly with this setup.
I have more things I need and can contribute but I'd like to get this into the gem so I can use it. :)