-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nginx): add an option to set static ip for clusterIP service #1623
Conversation
18ef086
to
be06e2d
Compare
Thanks for contributing to harbor-helm! Please undo the change in this file:
BTW, also I see there is a large diff on |
Why your env is |
I roll-backed changes on |
Actually, we run self-hosted GitLab runners in a Kubernetes cluster in which we mounted the docker socket of all jobs' executors to their corresponding nodes. Therefore, we needed to access the harbor nginx service from nodes, and to achieve this functionality, we had to create a static IP service for harbor and a host alias in all nodes. (didn't want to expose the harbor by ingress or node port) |
6841405
to
4fbd450
Compare
templates/nginx/service.yaml
Outdated
@@ -13,6 +13,9 @@ metadata: | |||
{{- end }} | |||
spec: | |||
type: ClusterIP | |||
{{- if .Values.expose.clusterIP.staticClusterIP }} | |||
clusterIP: {{ .Values.expose.clusterIP.clusterIP }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 17. it should also be .Values.expose.clusterIP.staticClusterIP
I suppose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're totally right, Fixed.
@Adibov , please rebase main branch code and resolve the conflicts in |
Signed-off-by: amirhesam.adibinia <[email protected]>
Signed-off-by: amirhesam.adibinia <[email protected]> Signed-off-by: Adibov <[email protected]>
Signed-off-by: Adibov <[email protected]>
f353526
to
20ac847
Compare
Signed-off-by: Adibov <[email protected]>
20ac847
to
e7172dd
Compare
Signed-off-by: Adibov <[email protected]>
Signed-off-by: Adibov <[email protected]>
Rebased to the main branch and resolved conflicts. Any more comment would be welcomed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I needed to create a clusterIP service for nginx which has static IP and there was no option to do so, therefore I created this MR to solve this issue.