Add recommended labels

[xoanmi]

Adding recommended labels based on: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

Close #1704

[Vad1mo]

This is also related to #1471

[Vad1mo]

Did you try and verify the upgrade backwards compatibility?

[xoanmi]

Did you try and verify the upgrade backwards compatibility?

Good catch! I've removed the new labels from the matchSelector as it is immutable. Now the change is backwards compatible 🎉

Install latest

➜ helm install harbor harbor/harbor \
    --set externalURL=http://core.harbor.domain \
    --set expose.ingress.hosts.core=core.harbor.domain \
    --set persistence.enabled=false
NAME: harbor
LAST DEPLOYED: Wed Feb 14 12:45:49 2024
NAMESPACE: harbor
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
Please wait for several minutes for Harbor deployment to complete.
Then you should be able to visit the Harbor portal at http://core.harbor.domain
For more details, please visit https://github.com/goharbor/harbor

Upgrade from release

➜ helm upgrade harbor . \
    --set externalURL=http://core.harbor.domain \
    --set expose.ingress.hosts.core=core.harbor.domain \
    --set persistence.enabled=false
Release "harbor" has been upgraded. Happy Helming!
NAME: harbor
LAST DEPLOYED: Wed Feb 14 12:55:45 2024
NAMESPACE: harbor
STATUS: deployed
REVISION: 4
TEST SUITE: None
NOTES:
Please wait for several minutes for Harbor deployment to complete.
Then you should be able to visit the Harbor portal at http://core.harbor.domain
For more details, please visit https://github.com/goharbor/harbor

[xoanmi]

@Vad1mo could you please review this PR? I think it's a very innocuous change and could be merged without further discussion, isn't it?

[Vad1mo]

I am all in here, need to test it thou first to see the backward compatibility.

[zyyw]

Do we have a strong reason why we need to add the Standard labels, instead of using the current labels. Is there any project that also add the Standard labels in addition to the their current ones?

[xoanmi]

Do we have a strong reason why we need to add the Standard labels, instead of using the current labels. Is there any project that also add the Standard labels in addition to the their current ones?

In general, all projects use the standard labels. I didn't delete the custom ones to not break retro compatibility.

I see it the other way around: Is there any compelling reason not to use the recommended labels? Labels are for free and there is no risk to break anything so why don't do it?

[xoanmi]

In addition, we have in place some processes that require the presence of those standard labels in all the deployments. That's our main reason to request adding them here :)

[zyyw]

Thank you for contributing to harbor-helm project!

[xoanmi]

Thank you for contributing to harbor-helm project!

@zyyw could we merge this PR?

[cvegagimenez]

Hi @zyyw ,

do you know when this change will be added to a new release?

[zyyw]

Hi @zyyw ,

do you know when this change will be added to a new release?

If everything goes well, it should be available in the 2nd half of May or early of June.

[zyyw]

FYI, if we set persistence.enabled=true, the upgrading process will be failed as mentioned in this issue:

• Helm upgrade failed when upgrade from 1.14(Harbor 2.10) to (Harbor 2.11) #1747

Created a PR to resolve this upgrading issue:

• add "harbor.legacy.labels" to resolve the upgrade issue 1747 #1749