Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry Metrics for Middlewares #42

Merged
merged 10 commits into from
Apr 23, 2024
Merged

OpenTelemetry Metrics for Middlewares #42

merged 10 commits into from
Apr 23, 2024

Conversation

ajatprabha
Copy link
Member

Add OTel implementations of middlewares for metrics support.

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 99.24812% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.77%. Comparing base (698c3a9) to head (d1c4690).

Files Patch % Lines
otelcourier/metric.go 97.05% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   99.87%   99.77%   -0.10%     
==========================================
  Files          35       37       +2     
  Lines         802      900      +98     
==========================================
+ Hits          801      898      +97     
- Misses          1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dhruvjain99 dhruvjain99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also instrument number of connected clients?

otelcourier/publish_test.go Show resolved Hide resolved
@ajatprabha ajatprabha merged commit f0fcd5e into main Apr 23, 2024
3 checks passed
@ajatprabha ajatprabha deleted the otel-metrics branch April 23, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants