Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issuer parsing and SteamGuard encoding #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tschwery
Copy link

These changes automatically parse the issuer if specified in the URL.

If the issuer is Steam, it uses the SteamGuard encoding that returns a code on 5 chars with a specific alphabet.

@qbit
Copy link
Collaborator

qbit commented Oct 28, 2018

Is the SteamGuard encoding documented anywhere?

I am not particularly a fan of adding per issuer logic into the lib. Maybe an optional callback to the OTP function would be better suited to handle this sort of thing.

@tschwery
Copy link
Author

No, it is not documented. It's more "examples floating around" than a proper documentation.
I can totally understand that you are not a fan of adding a specific, undocumented format to the library.

Yes, a callback could allow changing only a portion of the behavior (in this case generating the OTP string from the counter), I will look into this direction.

@kisom
Copy link
Member

kisom commented Oct 31, 2018

fwiw I don't really have a problem with this, but you could also take the same approach I did with Google TOTPs.

@qbit
Copy link
Collaborator

qbit commented Oct 31, 2018

The google approach would also not change the function def. I’d be fine with that as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants