Skip to content

Commit

Permalink
cmd/bench: increase timeout for gopls tests to 180m
Browse files Browse the repository at this point in the history
With recently added benchmarks, gopls benchmarks are starting to time
out.

Increase to 180m for now; we'll revisit if the benchmarks can be made
faster.

Change-Id: I2f60a8b606bebaaffac347173bdd064646e2a5fc
Reviewed-on: https://go-review.googlesource.com/c/benchmarks/+/530915
Auto-Submit: Robert Findley <[email protected]>
Reviewed-by: Nooras Saba‎ <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
  • Loading branch information
findleyr authored and gopherbot committed Sep 25, 2023
1 parent 84f2805 commit 1082dde
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/bench/gotest.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func goTestSubrepo(tc *toolchain, subRepo, baselineDir, experimentDir string) er
fmt.Printf("toolchain: %s\n", test.name) // set the toolchain tag

goplsPath := filepath.Join(test.goplsDir, "gopls")
err = tc.Do(benchmarkDir, "test", "-short", "-bench=.", fmt.Sprintf(`-gopls_path=%s`, goplsPath), "-count=5", "-timeout=60m")
err = tc.Do(benchmarkDir, "test", "-short", "-bench=.", fmt.Sprintf(`-gopls_path=%s`, goplsPath), "-count=5", "-timeout=180m")
if err != nil {
return fmt.Errorf("error running sub-repo %s benchmark %q with toolchain %s in dir %s: %w", subRepo, test.name, tc.Name, benchmarkDir, err)
}
Expand Down

0 comments on commit 1082dde

Please sign in to comment.