Remove Setup-Go (#403)

* Remove Setup-Go Signed-off-by: Steve Coffman <[email protected]> * Add setup-go to test github actions Signed-off-by: Steve Coffman <[email protected]> * Modify README and action.yml per review Signed-off-by: Steve Coffman <[email protected]> * build dist Co-authored-by: Sergey Vilgelm <[email protected]>
golangci · Feb 24, 2022 · 423fbaf · 423fbaf
1 parent bcfc6f9
commit 423fbaf
Show file tree

Hide file tree

Showing 10 changed files with 49,143 additions and 48,240 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -11,6 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+      - uses: actions/setup-go@v2
       - run: |
           npm install
           npm run all
@@ -33,6 +34,7 @@ jobs:
       pull-requests: read
     steps:
       - uses: actions/checkout@v2
+      - uses: actions/setup-go@v2
       - uses: ./
         with:
           version: ${{ matrix.version }}
@@ -51,6 +53,7 @@ jobs:
       contents: read
     steps:
       - uses: actions/checkout@v2
+      - uses: actions/setup-go@v2
       - uses: ./
         with:
           working-directory: sample-go-mod

diff --git a/README.md b/README.md
@@ -36,6 +36,7 @@ jobs:
     name: lint
     runs-on: ubuntu-latest
     steps:
+      - uses: actions/setup-go@v2
       - uses: actions/checkout@v2
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v2
@@ -52,9 +53,6 @@ jobs:
           # Optional: show only new issues if it's a pull request. The default value is `false`.
           # only-new-issues: true
 
-          # Optional: if set to true then the action will use pre-installed Go.
-          # skip-go-installation: true
-
           # Optional: if set to true then the action don't cache or restore ~/go/pkg.
           # skip-pkg-cache: true
 
@@ -92,6 +90,7 @@ jobs:
     name: lint
     runs-on: ${{ matrix.os }}
     steps:
+      - uses: actions/setup-go@v2
       - uses: actions/checkout@v2
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v2
@@ -133,7 +132,6 @@ The action was implemented with performance in mind:
 
 For example, in a repository of [golangci-lint](https://github.com/golangci/golangci-lint) running this action without the cache takes 50s, but with cache takes 14s:
   * in parallel:
-    * 13s to download Go
     * 4s to restore 50 MB of cache
     * 1s to find and install `golangci-lint`
   * 1s to run `golangci-lint` (it takes 35s without cache)
@@ -153,7 +151,6 @@ Inside our action we perform 3 steps:
   * restore [cache](https://github.com/actions/cache) of previous analyzes
   * fetch [action config](https://github.com/golangci/golangci-lint/blob/master/assets/github-action-config.json) and find the latest `golangci-lint` patch version
     for needed version (users of this action can specify only minor version of `golangci-lint`). After that install [golangci-lint](https://github.com/golangci/golangci-lint) using [@actions/tool-cache](https://github.com/actions/toolkit/tree/master/packages/tool-cache)
-  * install the latest Go 1.x version using [@actions/setup-go](https://github.com/actions/setup-go)
 2. Run `golangci-lint` with specified by user `args`
 3. Save cache for later builds
 

diff --git a/action.yml b/action.yml
@@ -20,10 +20,6 @@ inputs:
     description: "if set to true and the action runs on a pull request - the action outputs only newly found issues"
     default: false
     required: true
-  skip-go-installation:
-    description: "if set to true then action uses pre-installed Go"
-    default: false
-    required: true
   skip-pkg-cache:
     description: "if set to true then the action doesn't cache or restore ~/go/pkg."
     default: false