add option for never deleting records from db

[jefk]

The default behavior of the gem will delete records when destroy is called twice. I added an option, :never_delete, so a record will never be deleted from the database by calling destroy.

I don't really like the name of the option, but I couldn't think of anything better. I'm open to other ideas.

[christopherchiu]

I did find it mildly confusing that calling destroy on something twice would trigger a delete. I wonder if there are people out there taking advantage of that feature. Maybe we should make this a default? I would rather not add too many options.

[donv]

Calling destroy twice to force delete is bad. We have used destroy! with the exclamation mark to force deletion. Having a separate method for it is better.

[jefk]

It would be good to never delete by default, although I'm guessing that would cause unexpected behavior to people using the double delete feature.

[christopherchiu]

Yea, unfortunately this gem deals with pretty sensitive issues so switching core functionality like that can be bad. Although, the worst that could happen is things don't get deleted when they were expected to, which is much better than the opposite. Let's keep this in mind, maybe make it the default on a major version upgrade.

[zzak]

Also considering this for a future version.