Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: workaround go-get-insecure for rsc.io/pdf #255

Merged
merged 1 commit into from
Apr 7, 2016

Conversation

sbinet
Copy link
Member

@sbinet sbinet commented Apr 7, 2016

while the go get rsc.io/pdf failure is fixed upstream
(rsc/pdf#4), check out manually the repository from github and put it
in the correct place under $GOPATH.

while the `go get rsc.io/pdf` failure is fixed upstream
(rsc/pdf#4), check out manually the repository from github and put it
in the correct place under $GOPATH.
@eaburns
Copy link
Member

eaburns commented Apr 7, 2016

LGTM.

@eaburns
Copy link
Member

eaburns commented Apr 7, 2016

Actually, can you pass -insecure to go get instead?
It works for me locally:

$ go get rsc.io/pdf
package rsc.io/pdf: unrecognized import path "rsc.io/pdf" (https fetch: Get https://rsc.io/pdf?go-get=1: x509: certificate signed by unknown authority)
$ go get -insecure rsc.io/pdf
$ echo $?
0

@sbinet
Copy link
Member Author

sbinet commented Apr 7, 2016

you could, but go get -insecure was introduced some time after 1.4.3.
I am not sure if #define are possible in .travis.yml files... :)

@eaburns
Copy link
Member

eaburns commented Apr 7, 2016

OK then this is fine.

@sbinet sbinet merged commit 8730bf6 into gonum:master Apr 7, 2016
@sbinet sbinet deleted the rsc-io-fix branch April 7, 2016 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants