fix: propagate context with ff

- fix FF propagation - update test snapshots JIRA: LX-183 risk: low
gooddata · Jun 20, 2024 · 6ce99d3 · 6ce99d3
1 parent 847cc62
commit 6ce99d3
Show file tree

Hide file tree

Showing 6 changed files with 204 additions and 4 deletions.
diff --git a/libs/sdk-ui-filters/api/sdk-ui-filters.api.md b/libs/sdk-ui-filters/api/sdk-ui-filters.api.md
@@ -594,8 +594,7 @@ export type IAttributeFilterHandlerOptions = ISingleSelectAttributeFilterHandler
 
 // @public
 export interface IAttributeFilterHandlerOptionsBase {
-    // (undocumented)
-    displayAsLabel: ObjRef;
+    displayAsLabel?: ObjRef;
     enableDuplicatedLabelValuesInAttributeFilter?: boolean;
     hiddenElements?: string[];
     staticElements?: IAttributeElement[];

diff --git a/libs/sdk-ui-filters/src/AttributeFilterHandler/factory.ts b/libs/sdk-ui-filters/src/AttributeFilterHandler/factory.ts
@@ -53,7 +53,10 @@ export interface IAttributeFilterHandlerOptionsBase {
      */
     enableDuplicatedLabelValuesInAttributeFilter?: boolean;
 
-    displayAsLabel: ObjRef;
+    /**
+     * If specified, the attribute filter will display the elements in specified label form.
+     */
+    displayAsLabel?: ObjRef;
 }
 
 /**

diff --git a/...rc/AttributeFilterHandler/internal/redux/loadNextElementsPage/loadNextElementsPageSaga.ts b/...rc/AttributeFilterHandler/internal/redux/loadNextElementsPage/loadNextElementsPageSaga.ts
@@ -72,7 +72,7 @@ export function* loadNextElementsPageSaga(
 
         const result = yield call(elementsSaga, loadOptionsWithExcludePrimaryLabel, cacheId);
 
-        yield put(actions.loadNextElementsPageSuccess({ ...result, correlation }));
+        yield put(actions.loadNextElementsPageSuccess({ ...result, correlation, context }));
     } catch (error) {
         yield put(
             actions.loadNextElementsPageError({

diff --git a/...-ui-filters/src/AttributeFilterHandler/test/__snapshots__/loadCustomElements.test.ts.snap b/...-ui-filters/src/AttributeFilterHandler/test/__snapshots__/loadCustomElements.test.ts.snap
@@ -29,6 +29,72 @@ exports[`AttributeFilterHandler > loadCustomElements() that was successful shoul
 [
   {
     "cacheId": undefined,
+    "context": {
+      "attributeFilter": {
+        "positiveAttributeFilter": {
+          "displayForm": {
+            "identifier": "label.f_product.product.name",
+            "type": "displayForm",
+          },
+          "in": {
+            "uris": [
+              "/gdc/md/referenceworkspace/obj/1054/elements?id=165678",
+              "/gdc/md/referenceworkspace/obj/1054/elements?id=165847",
+            ],
+          },
+        },
+      },
+      "backend": {
+        "authenticate": [Function],
+        "capabilities": {
+          "allowsInconsistentRelations": false,
+          "canCalculateGrandTotals": true,
+          "canCalculateNativeTotals": true,
+          "canCalculateSubTotals": true,
+          "canCalculateTotals": true,
+          "supportsCsvUploader": true,
+          "supportsCustomColorPalettes": true,
+          "supportsElementUris": true,
+          "supportsElementsQueryParentFiltering": true,
+          "supportsEveryoneUserGroupForAccessControl": true,
+          "supportsHierarchicalWorkspaces": false,
+          "supportsKpiWidget": false,
+          "supportsOwners": true,
+          "supportsWidgetEntity": true,
+        },
+        "config": {
+          "attributeElementsFiltering": {
+            "attributeFilters": {
+              "label.f_product.product.name": [Function],
+            },
+            "dateFilters": {
+              "dt_snapshotdate_timestamp.day": [Function],
+            },
+            "measures": {
+              "87a053b0-3947-49f3-b0c5-de53fd01f050": [Function],
+            },
+          },
+        },
+        "currentUser": [Function],
+        "dataSources": [Function],
+        "deauthenticate": [Function],
+        "entitlements": [Function],
+        "isAuthenticated": [Function],
+        "onHostname": [Function],
+        "organization": [Function],
+        "organizations": [Function],
+        "withAuthentication": [Function],
+        "withTelemetry": [Function],
+        "workspace": [Function],
+        "workspaces": [Function],
+      },
+      "displayAsLabel": undefined,
+      "enableDuplicatedLabelValuesInAttributeFilter": undefined,
+      "eventListener": [Function],
+      "hiddenElements": undefined,
+      "staticElements": undefined,
+      "workspace": "testWorkspace",
+    },
     "correlation": "success",
     "elements": [
       {

diff --git a/...ilters/src/AttributeFilterHandler/test/__snapshots__/loadInitialElementsPage.test.ts.snap b/...ilters/src/AttributeFilterHandler/test/__snapshots__/loadInitialElementsPage.test.ts.snap
@@ -184,6 +184,72 @@ exports[`AttributeFilterHandler > loadInitialElementsPage() that was successful
 [
   {
     "cacheId": undefined,
+    "context": {
+      "attributeFilter": {
+        "positiveAttributeFilter": {
+          "displayForm": {
+            "identifier": "label.f_product.product.name",
+            "type": "displayForm",
+          },
+          "in": {
+            "uris": [
+              "/gdc/md/referenceworkspace/obj/1054/elements?id=165678",
+              "/gdc/md/referenceworkspace/obj/1054/elements?id=165847",
+            ],
+          },
+        },
+      },
+      "backend": {
+        "authenticate": [Function],
+        "capabilities": {
+          "allowsInconsistentRelations": false,
+          "canCalculateGrandTotals": true,
+          "canCalculateNativeTotals": true,
+          "canCalculateSubTotals": true,
+          "canCalculateTotals": true,
+          "supportsCsvUploader": true,
+          "supportsCustomColorPalettes": true,
+          "supportsElementUris": true,
+          "supportsElementsQueryParentFiltering": true,
+          "supportsEveryoneUserGroupForAccessControl": true,
+          "supportsHierarchicalWorkspaces": false,
+          "supportsKpiWidget": false,
+          "supportsOwners": true,
+          "supportsWidgetEntity": true,
+        },
+        "config": {
+          "attributeElementsFiltering": {
+            "attributeFilters": {
+              "label.f_product.product.name": [Function],
+            },
+            "dateFilters": {
+              "dt_snapshotdate_timestamp.day": [Function],
+            },
+            "measures": {
+              "87a053b0-3947-49f3-b0c5-de53fd01f050": [Function],
+            },
+          },
+        },
+        "currentUser": [Function],
+        "dataSources": [Function],
+        "deauthenticate": [Function],
+        "entitlements": [Function],
+        "isAuthenticated": [Function],
+        "onHostname": [Function],
+        "organization": [Function],
+        "organizations": [Function],
+        "withAuthentication": [Function],
+        "withTelemetry": [Function],
+        "workspace": [Function],
+        "workspaces": [Function],
+      },
+      "displayAsLabel": undefined,
+      "enableDuplicatedLabelValuesInAttributeFilter": undefined,
+      "eventListener": [Function],
+      "hiddenElements": undefined,
+      "staticElements": undefined,
+      "workspace": "testWorkspace",
+    },
     "correlation": "success",
     "elements": [
       {

diff --git a/...i-filters/src/AttributeFilterHandler/test/__snapshots__/loadNextElementsPage.test.ts.snap b/...i-filters/src/AttributeFilterHandler/test/__snapshots__/loadNextElementsPage.test.ts.snap
@@ -69,6 +69,72 @@ exports[`AttributeFilterHandler > loadNextElementsPage() that was successful sho
 [
   {
     "cacheId": undefined,
+    "context": {
+      "attributeFilter": {
+        "positiveAttributeFilter": {
+          "displayForm": {
+            "identifier": "label.f_product.product.name",
+            "type": "displayForm",
+          },
+          "in": {
+            "uris": [
+              "/gdc/md/referenceworkspace/obj/1054/elements?id=165678",
+              "/gdc/md/referenceworkspace/obj/1054/elements?id=165847",
+            ],
+          },
+        },
+      },
+      "backend": {
+        "authenticate": [Function],
+        "capabilities": {
+          "allowsInconsistentRelations": false,
+          "canCalculateGrandTotals": true,
+          "canCalculateNativeTotals": true,
+          "canCalculateSubTotals": true,
+          "canCalculateTotals": true,
+          "supportsCsvUploader": true,
+          "supportsCustomColorPalettes": true,
+          "supportsElementUris": true,
+          "supportsElementsQueryParentFiltering": true,
+          "supportsEveryoneUserGroupForAccessControl": true,
+          "supportsHierarchicalWorkspaces": false,
+          "supportsKpiWidget": false,
+          "supportsOwners": true,
+          "supportsWidgetEntity": true,
+        },
+        "config": {
+          "attributeElementsFiltering": {
+            "attributeFilters": {
+              "label.f_product.product.name": [Function],
+            },
+            "dateFilters": {
+              "dt_snapshotdate_timestamp.day": [Function],
+            },
+            "measures": {
+              "87a053b0-3947-49f3-b0c5-de53fd01f050": [Function],
+            },
+          },
+        },
+        "currentUser": [Function],
+        "dataSources": [Function],
+        "deauthenticate": [Function],
+        "entitlements": [Function],
+        "isAuthenticated": [Function],
+        "onHostname": [Function],
+        "organization": [Function],
+        "organizations": [Function],
+        "withAuthentication": [Function],
+        "withTelemetry": [Function],
+        "workspace": [Function],
+        "workspaces": [Function],
+      },
+      "displayAsLabel": undefined,
+      "enableDuplicatedLabelValuesInAttributeFilter": undefined,
+      "eventListener": [Function],
+      "hiddenElements": undefined,
+      "staticElements": undefined,
+      "workspace": "testWorkspace",
+    },
     "correlation": "success",
     "elements": [
       {