Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to disable local saving and reset filter #5048

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

hackerstanislav
Copy link
Contributor

Query params to handle

  • Disable cross filtering
  • Disable reset button
  • Disable save filters

risk: low
JIRA: F1-427


Important

Please, don't forget to run rush change for the commits that introduce new features 🙏


Refer to documentation to see how to run checks and tests in the pull request. This is the list of the most used commands:

extended test - backstop
extended test - tiger-cypress - integrated
extended test - tiger-cypress - isolated
extended test - tiger-cypress - record

@gooddata
Copy link

gooddata bot commented Jun 24, 2024

Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/20929/ finished with 'FAILURE' status.

@gooddata
Copy link

gooddata bot commented Jun 24, 2024

Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/20930/ finished with 'SUCCESS' status.

 Query params to handle
  - Disable cross filtering
  - Disable reset button
  - Disable save filters

risk: low
JIRA: F1-427
@gooddata
Copy link

gooddata bot commented Jun 24, 2024

Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/20931/ finished with 'SUCCESS' status.

Copy link
Contributor

@kandl kandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hackerstanislav hackerstanislav added this pull request to the merge queue Jun 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 24, 2024
@hackerstanislav hackerstanislav added this pull request to the merge queue Jun 24, 2024
@gooddata
Copy link

gooddata bot commented Jun 24, 2024

Job gooddata-ui-sdk-cypress-tiger-isolated-zuul-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-cypress-tiger-isolated-zuul-pipeline/2081/ finished with 'UNSTABLE' status.

@gooddata
Copy link

gooddata bot commented Jun 24, 2024

Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/20934/ finished with 'SUCCESS' status.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 24, 2024
@hackerstanislav hackerstanislav added this pull request to the merge queue Jun 24, 2024
@gooddata
Copy link

gooddata bot commented Jun 24, 2024

Job gooddata-ui-sdk-cypress-tiger-isolated-zuul-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-cypress-tiger-isolated-zuul-pipeline/2085/ finished with 'UNSTABLE' status.

@gooddata
Copy link

gooddata bot commented Jun 24, 2024

Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/20941/ finished with 'SUCCESS' status.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 24, 2024
@hackerstanislav hackerstanislav added this pull request to the merge queue Jun 26, 2024
@gooddata
Copy link

gooddata bot commented Jun 26, 2024

Job gooddata-ui-sdk-cypress-tiger-isolated-zuul-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-cypress-tiger-isolated-zuul-pipeline/2101/ finished with 'SUCCESS' status.

@gooddata
Copy link

gooddata bot commented Jun 26, 2024

Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/20966/ finished with 'SUCCESS' status.

Merged via the queue into master with commit 4fe404d Jun 26, 2024
3 checks passed
@hackerstanislav hackerstanislav deleted the SHA_F1-413 branch June 26, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants