-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle export raw data #5557
Conversation
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/22354/ finished with 'FAILURE' status. |
343d5db
to
af2f77a
Compare
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/22364/ finished with 'FAILURE' status. |
7e05568
to
d67c426
Compare
extended test - tiger-cypress - integrated |
@@ -1561,6 +1568,53 @@ export const buildTigerSpecificFunctions = ( | |||
}); | |||
}, | |||
|
|||
exportRawData: async (execution, projectId, fileName) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering whether we need this in tiger specific functions, when we have https://github.com/gooddata/gooddata-ui-sdk/pull/5557/files#diff-79080bcabf02f4997926c1c0771b1859b77386063ce55e3fa49fc68fcc6b8b3fR289.
I don't see it used, but I may be missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, removed the specific endpoint call from tigerSpecificFunctions
and use global introduced as part of execution result.
d67c426
to
a39dbad
Compare
risk: low JIRA: LX-646
a39dbad
to
0e74fb7
Compare
risk: low
JIRA: LX-646
Important
Please, don't forget to run
rush change
for the commits that introduce new features 🙏Refer to documentation to see how to run checks and tests in the pull request. This is the list of the most used commands: