Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle export raw data #5557

Merged
merged 1 commit into from
Feb 24, 2025
Merged

feat: handle export raw data #5557

merged 1 commit into from
Feb 24, 2025

Conversation

NestorEncinas
Copy link
Contributor

risk: low
JIRA: LX-646


Important

Please, don't forget to run rush change for the commits that introduce new features 🙏


Refer to documentation to see how to run checks and tests in the pull request. This is the list of the most used commands:

extended test - backstop
extended test - tiger-cypress - integrated
extended test - tiger-cypress - isolated
extended test - tiger-cypress - record

@NestorEncinas NestorEncinas requested a review from kandl as a code owner November 14, 2024 09:42
@gooddata
Copy link

gooddata bot commented Nov 14, 2024

Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/22354/ finished with 'FAILURE' status.

@NestorEncinas NestorEncinas added the do not merge Do not merge this yet label Nov 14, 2024
@gooddata
Copy link

gooddata bot commented Nov 14, 2024

Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/22364/ finished with 'FAILURE' status.

@NestorEncinas NestorEncinas force-pushed the nen-lx-646 branch 5 times, most recently from 7e05568 to d67c426 Compare February 20, 2025 12:51
@NestorEncinas
Copy link
Contributor Author

extended test - tiger-cypress - integrated

@NestorEncinas NestorEncinas added ready to review PR is ready to final code review and removed do not merge Do not merge this yet ready to review PR is ready to final code review labels Feb 20, 2025
@@ -1561,6 +1568,53 @@ export const buildTigerSpecificFunctions = (
});
},

exportRawData: async (execution, projectId, fileName) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether we need this in tiger specific functions, when we have https://github.com/gooddata/gooddata-ui-sdk/pull/5557/files#diff-79080bcabf02f4997926c1c0771b1859b77386063ce55e3fa49fc68fcc6b8b3fR289.
I don't see it used, but I may be missing something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, removed the specific endpoint call from tigerSpecificFunctions and use global introduced as part of execution result.

risk: low
JIRA: LX-646
@pbenes pbenes enabled auto-merge February 24, 2025 11:04
@pbenes pbenes merged commit d4c1502 into master Feb 24, 2025
15 checks passed
@pbenes pbenes deleted the nen-lx-646 branch February 24, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review PR is ready to final code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants